Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-test: run 182 of 193 tests #34

Merged
merged 1 commit into from
Oct 4, 2019
Merged

core-test: run 182 of 193 tests #34

merged 1 commit into from
Oct 4, 2019

Conversation

greut
Copy link
Member

@greut greut commented Sep 30, 2019

It's currently only 179.

andreynering
andreynering approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there 🙂

@xuhdev
Copy link
Member

xuhdev commented Oct 4, 2019

Please also take editorconfig/editorconfig-core-test#28 into consideration: Some tests may be expected to fail for now.

@greut
Copy link
Member Author

greut commented Oct 4, 2019

@xuhdev interesting. A CircleCI configuration might be of use to play with the CR, LF, CRLF variations.

@greut greut merged commit deadc4d into editorconfig:master Oct 4, 2019
@greut greut deleted the run-more-tests branch October 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreynering andreynering andreynering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greut @xuhdev @andreynering